CODE128.js ➔ ??? - Code Metrics - Inspection of "[WIP] Refactor CODE128" - lindell/JsBarcode - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#150)

unknown

created 2017-05-13 14:25 UTC

CODE128.js ➔ ??? A

↳ Parent: src/barcodes/CODE128/CODE128.js

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	1
c	4
b	0
f	0
nc	1
nop	2
dl	0
loc	7
rs	9.4285

1 Function

Rating	Name	Duplication	Size	Complexity
A	CODE128.js ➔ ... ➔ ???	0	1	1

import Barcode from "../Barcode.js";
import { SHIFT, SET_A, SET_B, MODULO, STOP, ABC, SWAP, BARS } from './constants';

// This is the master class,
// it does require the start code to be included in the string
class CODE128 extends Barcode {
	constructor(data, options) {
		super(data.substring(1), options);

		// Get array of ascii codes from data
		this.bytes = data.split('')
			.map(char => char.charCodeAt(0));
	}

	valid() {
		// ASCII value ranges 0-127, 200-211
		return /^[\x00-\x7F\xC8-\xD3]+$/.test(this.data);
	}

	// The public encoding function
	encode() {
		const bytes = this.bytes;
		// Remove the start code from the bytes and set its index
		const startIndex = bytes.shift() - 105;
		// Get start set by index
		const startSet = ABC[startIndex];

		if (startSet === undefined) {
			throw new RangeError('The encoding does not start with a start character.');
		}

		// Start encode with the right type
		const encodingResult = CODE128.next(bytes, 1, startSet);

		return {
			text:
				this.text === this.data
					? this.text.replace(/[^\x20-\x7E]/g, '')
					: this.text,
			data:
				// Add the start bits
				CODE128.getEncoding(startIndex) +
				// Add the encoded bits
				encodingResult.result +
				// Add the checksum
				CODE128.getEncoding((encodingResult.checksum + startIndex) % MODULO) +
				// Add the end bits
				CODE128.getEncoding(STOP)
		};
	}

	static getEncoding(code) {
		return BARS[code] || '';
	}

	static correctIndex(bytes, set) {
		if (set === SET_A) {
			const charCode = bytes.shift();
			return charCode < 32 ? charCode + 64 : charCode - 32;
		} else if (set === SET_B) {
			return bytes.shift() - 32;
		} else {
			return (bytes.shift() - 48) * 10 + bytes.shift() - 48;
		}
	}

	static next(bytes, pos, set) {
		if (!bytes.length) return { result: '', checksum: 0 };
if (a > 0)
    b = 42;
		let nextCode, index;

		// Special characters
		if (bytes[0] >= 200){
			index = bytes.shift() - 105;
			const nextSet = SWAP[index];

			// Swap to other set
			if (nextSet !== undefined) {
				nextCode = CODE128.next(bytes, pos + 1, nextSet);
			}
			// Continue on current set but encode a special character
			else {
				// Shift
				if ((set === SET_A || set === SET_B) && index === SHIFT) {
					// Convert the next character so that is encoded correctly
					bytes[0] = (set === SET_A)
						? bytes[0] > 95 ? bytes[0] - 96 : bytes[0]
						: bytes[0] < 32 ? bytes[0] + 96 : bytes[0];
				}
				nextCode = CODE128.next(bytes, pos + 1, set);
			}
		}
		// Continue encoding
		else {
			index = CODE128.correctIndex(bytes, set);
			nextCode = CODE128.next(bytes, pos + 1, set);
		}

		// Get the correct binary encoding and calculate the weight
		const enc = CODE128.getEncoding(index);
		const weight = index * pos;

		return {
			result: enc + nextCode.result,
			checksum: weight + nextCode.checksum
		};
	}
}

export default CODE128;


1			import Barcode from "../Barcode.js";
2			import { SHIFT, SET_A, SET_B, MODULO, STOP, ABC, SWAP, BARS } from './constants';
3
4			// This is the master class,
5			// it does require the start code to be included in the string
6			class CODE128 extends Barcode {
7			constructor(data, options) {
8			super(data.substring(1), options);
9
10			// Get array of ascii codes from data
11			this.bytes = data.split('')
12			.map(char => char.charCodeAt(0));
13			}
14
15			valid() {
16			// ASCII value ranges 0-127, 200-211
17			return /^[\x00-\x7F\xC8-\xD3]+$/.test(this.data);
18			}
19
20			// The public encoding function
21			encode() {
22			const bytes = this.bytes;
23			// Remove the start code from the bytes and set its index
24			const startIndex = bytes.shift() - 105;
25			// Get start set by index
26			const startSet = ABC[startIndex];
27
28			if (startSet === undefined) {
29			throw new RangeError('The encoding does not start with a start character.');
30			}
31
32			// Start encode with the right type
33			const encodingResult = CODE128.next(bytes, 1, startSet);
34
35			return {
36			text:
37			this.text === this.data
38			? this.text.replace(/[^\x20-\x7E]/g, '')
39			: this.text,
40			data:
41			// Add the start bits
42			CODE128.getEncoding(startIndex) +
43			// Add the encoded bits
44			encodingResult.result +
45			// Add the checksum
46			CODE128.getEncoding((encodingResult.checksum + startIndex) % MODULO) +
47			// Add the end bits
48			CODE128.getEncoding(STOP)
49			};
50			}
51
52			static getEncoding(code) {
53			return BARS[code] \|\| '';
54			}
55
56			static correctIndex(bytes, set) {
57			if (set === SET_A) {
58			const charCode = bytes.shift();
59			return charCode < 32 ? charCode + 64 : charCode - 32;
60			} else if (set === SET_B) {
61			return bytes.shift() - 32;
62			} else {
63			return (bytes.shift() - 48) * 10 + bytes.shift() - 48;
64			}
65			}
66
67			static next(bytes, pos, set) {
68			if (!bytes.length) return { result: '', checksum: 0 };
			0 ignored issues – show Coding Style Best Practice introduced 2017-05-13 14:06 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
69			let nextCode, index;
70
71			// Special characters
72			if (bytes[0] >= 200){
73			index = bytes.shift() - 105;
74			const nextSet = SWAP[index];
75
76			// Swap to other set
77			if (nextSet !== undefined) {
78			nextCode = CODE128.next(bytes, pos + 1, nextSet);
79			}
80			// Continue on current set but encode a special character
81			else {
82			// Shift
83			if ((set === SET_A \|\| set === SET_B) && index === SHIFT) {
84			// Convert the next character so that is encoded correctly
85			bytes[0] = (set === SET_A)
86			? bytes[0] > 95 ? bytes[0] - 96 : bytes[0]
87			: bytes[0] < 32 ? bytes[0] + 96 : bytes[0];
88			}
89			nextCode = CODE128.next(bytes, pos + 1, set);
90			}
91			}
92			// Continue encoding
93			else {
94			index = CODE128.correctIndex(bytes, set);
95			nextCode = CODE128.next(bytes, pos + 1, set);
96			}
97
98			// Get the correct binary encoding and calculate the weight
99			const enc = CODE128.getEncoding(index);
100			const weight = index * pos;
101
102			return {
103			result: enc + nextCode.result,
104			checksum: weight + nextCode.checksum
105			};
106			}
107			}
108
109			export default CODE128;
110

lindell / JsBarcode

Pull Request — master (#150)

CODE128.js ➔ ??? A

Complexity

Size

Duplication

Importance

1 Function

Duplication Side-by-Side

Filter issues like